search

boorik / smartfox-haxe-client

haxe openfl client for smartfoxserver
MIT License
18 stars 14 forks source link

WebSocket Support Added && BlueBox Fix #28

Closed barisyild closed 3 years ago

barisyild commented 4 years ago
Platform Support
HTML5 WS/WSS
Flash WS/WSS/Socket/BlueBox
Adobe AIR WS/Socket/BlueBox
Windows WS/WSS/Socket/BlueBox
Linux Untested
Mac OS Untested
Android Untested
iOS Untested
Neko Untested
Emscripten Untested
dpomier commented 3 years ago

I think SFSDataType.TEXT and JoinRoomInvitationRequest should come in 2 separate PR. That would make it easier to merge :)

Also, I have some interrogation wrt the current implementation; why don't you use openfl.net.Socket for the JS target? It is already a cross-platform implementation that uses web sockets on HTML5.

barisyild commented 3 years ago

Also, I have some interrogation wrt the current implementation; why don't you use openfl.net.Socket for the JS target? It is already a cross-platform implementation that uses web sockets on HTML5.

In this way, we can use websocket for all targets.

The advantage of using websockets for targets such as cpp and flash is to be able to use services such as cloudflare.

barisyild commented 3 years ago

Yes, as you said, it would be better to open more than one PR.