Try to duplicate less code

boost-R / gamboostLSS

Boosting models for fitting generalized additive models for location, shape and scale (GAMLSS) to potentially high dimensional data. The current relase version can be found on CRAN (https://cran.r-project.org/package=gamboostLSS).

26 stars 11 forks source link

Try to duplicate less code #24

Closed hofnerb closed 7 years ago

hofnerb commented 8 years ago

@ja-thomas, we should try to use better functional units to avoid duplication of code. Currently, we have a lot of spaghetti code instead of proper functional programming.

Can we aim for that in the next release, i.e. after the initial release of the non-cyclic fitting?

hofnerb commented 8 years ago

Perhaps we can furthermore already use object orientation within the fitting algorithm

ja-thomas commented 7 years ago

Should be better now. The code could be made nicer in the future, but that would require major refactoring (maybe even some on mboost). I don't think I have the time for that currently, but we can keep the issue open if you want to.