fix selected - Githubissues

boost-R / gamboostLSS

Boosting models for fitting generalized additive models for location, shape and scale (GAMLSS) to potentially high dimensional data. The current relase version can be found on CRAN (https://cran.r-project.org/package=gamboostLSS).

26 stars 11 forks source link

fix selected #41

Closed ja-thomas closed 7 years ago

ja-thomas commented 7 years ago

This should fix #39 and #40

I'll clean up and doc the code, then we can merge (if everything passes).

The problem was that with the update of mboost, mstop=0 is possible and risk has two more entries, but we have no selected BLs for these, which results in the errors

Also my editor is removing a lot of whitespaces, I'll fix that for the PR. But first let's see if the tests are running.

ja-thomas commented 7 years ago

Error: could not find function "glmboostLSS"
Execution halted

.... lol what

hofnerb commented 7 years ago

That is very weird!!!

ja-thomas commented 7 years ago

require(gamboostlSS) was missing from the new test

coveralls commented 7 years ago

Changes Unknown when pulling 33537acef75171f8c0a782320ffb3190baea0077 on fix_selected into on master.

coveralls commented 7 years ago

Changes Unknown when pulling 33537acef75171f8c0a782320ffb3190baea0077 on fix_selected into on master.

hofnerb commented 7 years ago

tüdüdü... Freitag abend...

ja-thomas commented 7 years ago

Should be good now, can be merged if everything is green, imo.

coveralls commented 7 years ago

Changes Unknown when pulling 1e606c72e9db6776a87b17e89291e744280665ec on fix_selected into on master.

hofnerb commented 7 years ago

what's the reason for using mstop = 20?