search

boost-R / mboost

Boosting algorithms for fitting generalized linear, additive and interaction models to potentially high-dimensional data. The current relase version can be found on CRAN (http://cran.r-project.org/package=mboost).
73 stars 27 forks source link

Improved PR #42

Closed hofnerb closed 8 years ago

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.004%) to 79.479% when pulling 251bca0bd3e7495bd622676686cc9b65b0f0a280 on hofnerb:patch-1 into 77ac6a25a0243bcf946c84c0a813528b557f4e89 on boost-R:master.

mvkorpel commented 8 years ago

Yes, there is no need to introduce a new variable to hold the matched function. It is just a personal habit of mine not to modify the arguments of a function. This is one of the things checked by codetools::checkUsagePackage("mboost", all = TRUE). Using the same name for an updated value is not a problem in this case, but may be in others, due to lazy evaluation employed by R. It is perfectly fine to modify an argument in many (most?) cases, and that is probably why the corresponding codetools check is not used by default, hence the all = TRUE.