Deprecated warning - Githubissues

boost-ext / di

C++14 Dependency Injection Library

https://boost-ext.github.io/di

1.14k stars 138 forks source link

Deprecated warning #452

Closed m-gaj closed 4 years ago

m-gaj commented 4 years ago

Problem:

Deprecated warnings were treated as errors after including di.hpp

Solution:

Push-pragma moved to deactivate the error-pragma at the end of the file

Issue: #

Reviewers: @

krzysztof-jusiak commented 4 years ago

Thanks @m-gaj, would you be able to squash the commits, please? Also, to make the change persistent we also should change https://github.com/boost-experimental/di/blob/cpp14/tools/pph.sh#L42 which is used to generate di.hpp, otherwise, the change will be reverted if anyone will regenerate the file.

Thanks :+1:

m-gaj commented 4 years ago

Hi, I added the change in the pph.sh and squashed it all into one commit.

krzysztof-jusiak commented 4 years ago

Awesome, thank you @m-gaj :+1: