Closed chosungmann closed 3 years ago
Oh, I'm so sorry @chosungmann I missed your PR somehow :disappointed: and just noticed it. Feel really bad about it. We defo want something to allow an arbitrary number of constructor parameters for the constructors but in the same sentence, one of the DI principles is to avoid STL dependency. Let me iterate on this one, thank you for your PR and sorry again :disappointed:
Fixed by https://github.com/boost-ext/di/pull/505 @chosungmann, sorry again :disappointed:
@krzysztof-jusiak no worries! #505 looks so elegant and beautiful! thanks!
:pray:
Problem:
Solution:
BOOST_DI_CFG_CTOR_LIMIT_SIZE currently doesn't work on Visual Studio. The same problem was raised in #271 and #273, and resolved in #426, but for unknown reasons, the solution was applied only to GCC. The #426's approach is very intuitive and concise than other methods, and works well with most modern compilers other than GCC. This PR suggests using the #426's approach to resolve BOOST_DI_CFG_CTOR_LIMIT_SIZE problems whenever available.
Issue: #271, #273
Reviewers: @krzysztof-jusiak