boostercloud / booster

Booster Framework
https://www.boosterframework.com
Apache License 2.0
419 stars 87 forks source link

Configure rush so it generates one single tag instead of tag per package #1216

Open NickSeagull opened 2 years ago

NickSeagull commented 2 years ago

Bug Report

Current Behavior

When using rush to create a new version of Booster, the current configuration generates a tag for each package, forcing us to manually create the vX.Y.Z tag.

Expected behavior

When a new version is published during CI/CD, the last commit is tagged with a single tag in the format vX.Y.Z.

Ideally, a new GitHub release should be created, filled with the latest changes from the changelog file (packages/framework-core/CHANGELOG.md)

Possible Solution

Update the rush configuration to generate a single tag for the entire monorepo instead of a tag for each package.

Checklist - [X] ``rush.json`` ⚠️ No Changes Made - [X] ``common/config/rush/version-policies.json`` ⚠️ No Changes Made - [ ] `.github/workflows/release.yml`
sweep-ai[bot] commented 1 year ago
Sweeping

50%
⚡ Sweep Basic Tier: I'm creating this ticket using GPT-4. You have 3 GPT-4 tickets left for the month and 1 for the day. For more GPT-4 tickets, visit our payment portal.

Actions (click)


Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/boostercloud/booster/blob/4e5a10307f9528e3bceb6d7cf6917544417c7e34/packages/framework-core/CHANGELOG.md#L25-L283 https://github.com/boostercloud/booster/blob/4e5a10307f9528e3bceb6d7cf6917544417c7e34/CONTRIBUTING.md#L215-L355 https://github.com/boostercloud/booster/blob/4e5a10307f9528e3bceb6d7cf6917544417c7e34/common/config/rush/version-policies.json#L1-L107 https://github.com/boostercloud/booster/blob/4e5a10307f9528e3bceb6d7cf6917544417c7e34/rush.json#L215-L415 https://github.com/boostercloud/booster/blob/4e5a10307f9528e3bceb6d7cf6917544417c7e34/rush.json#L1-L55

Step 2: ⌨️ Coding

npm i 1/1 ❌ (`254`)
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path /repo/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '/repo/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 
npm ERR! A complete log of this run can be found in: /root/.npm/_logs/2023-10-16T21_06_18_799Z-debug-0.log


Sandbox logs for b37f8de
npm i 1/1 ❌ (`254`)
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path /repo/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '/repo/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 
npm ERR! A complete log of this run can be found in: /root/.npm/_logs/2023-10-16T21_13_32_824Z-debug-0.log


Sandbox logs for b37f8de
npm i 1/1 ❌ (`254`)
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path /repo/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '/repo/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 
npm ERR! A complete log of this run can be found in: /root/.npm/_logs/2023-10-16T21_21_43_501Z-debug-0.log

npm i 1/1 ❌ (`254`)
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path /repo/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '/repo/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 
npm ERR! A complete log of this run can be found in: /root/.npm/_logs/2023-10-16T21_24_39_677Z-debug-0.log


Sandbox logs for 5ff59fb
npm i 1/1 ❌ (`254`)
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path /repo/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '/repo/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 
npm ERR! A complete log of this run can be found in: /root/.npm/_logs/2023-10-16T21_27_12_527Z-debug-0.log


Sandbox logs for 5ff59fb
npm i 1/1 ❌ (`254`)
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path /repo/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '/repo/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 
npm ERR! A complete log of this run can be found in: /root/.npm/_logs/2023-10-16T21_36_50_241Z-debug-0.log


Sandbox logs for 5ff59fb
npm i 1/1 ❌ (`254`)
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path /repo/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '/repo/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 
npm ERR! A complete log of this run can be found in: /root/.npm/_logs/2023-10-16T21_48_05_071Z-debug-0.log


Step 3: 🔁 Code Review

Working on it...


🎉 Latest improvements to Sweep:


💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. Join Our Discord