boostercloud / booster

Booster Framework
https://www.boosterframework.com
Apache License 2.0
416 stars 86 forks source link

Create host.json file if not exist #1402

Closed gonzalojaubert closed 1 year ago

ghost commented 1 year ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/boostercloud/booster/1402/f1686c8e/99da046b315cfed93b7af921da611d1eca396a04.svg)](https://app.codesee.io/r/reviews?pr=1402&src=https%3A%2F%2Fgithub.com%2Fboostercloud%2Fbooster) #### Legend CodeSee Map legend
gonzalogarciajaubert commented 1 year ago

/integration sha=99da046

github-actions[bot] commented 1 year ago

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] commented 1 year ago

:white_check_mark: Integration tests have finished successfully!

JYCabello commented 1 year ago

If I understand correctly, there's a change in the integration tests that takes this change into account, but neither a test verifying that the zip defaults nor one verifying that the provided one is used.

Is it feasible to unit test it?