search

boostercloud / booster

Booster Framework
https://www.boosterframework.com
Apache License 2.0
416 stars 86 forks source link

Read Models projections by ReadModel query #1469

Closed gonzalojaubert closed 2 months ago

gonzalojaubert commented 11 months ago

TODO refactor

ghost commented 11 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/boostercloud/booster/1469/2167ad7c/9ccb6d899e9fa78858a51a33a26aaf354a2fd8f1.svg)](https://app.codesee.io/r/reviews?pr=1469&src=https%3A%2F%2Fgithub.com%2Fboostercloud%2Fbooster) #### Legend CodeSee Map legend
gonzalogarciajaubert commented 10 months ago

/integration sha=8b61944

github-actions[bot] commented 10 months ago

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] commented 10 months ago

:x: Oh no! Integration tests have failed

gonzalogarciajaubert commented 10 months ago

/integration sha=f4dbdab

github-actions[bot] commented 10 months ago

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] commented 10 months ago

:white_check_mark: Integration tests have finished successfully!

gonzalogarciajaubert commented 10 months ago

/integration sha=c0d2976

github-actions[bot] commented 10 months ago

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] commented 10 months ago

:white_check_mark: Integration tests have finished successfully!

MarcAstr0 commented 5 months ago

/integration sha=7662e4adde9c4fc2fbabc04177a9891c6ab7ee2a

github-actions[bot] commented 5 months ago

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] commented 5 months ago

:white_check_mark: Integration tests have finished successfully!

MarcAstr0 commented 3 months ago

/integration sha=a690096

github-actions[bot] commented 3 months ago

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] commented 3 months ago

:white_check_mark: Integration tests have finished successfully!

MarcAstr0 commented 2 months ago

/integration sha=fb763a60b77ed42c7bf7fbd66e35a1150e4992ea

github-actions[bot] commented 2 months ago

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] commented 2 months ago

:white_check_mark: Integration tests have finished successfully!

davidverdu commented 2 months ago

In a first look addressing the tests and documentation, I have commented some lines of the codes pointing out issues about naming of functions. Maybe I'm being a bit nitpicky, but Booster is opinionated and for example, naming a function update inside a ReadModel is misleading (ReadModels implement Query operations and not update/insert operations as in Commands). We can see good examples in the official documentation:

Tomorrow I'll add the reviews on the rest of the code

MarcAstr0 commented 2 months ago

@davidverdu your suggestions related to method names have been applied in commit 393fade1a4102552e88f6d7d8105abc9d15df9ac :wink: :+1:

davidverdu commented 2 months ago

/integration sha=393fade

davidverdu commented 2 months ago

/integration sha=393fade

github-actions[bot] commented 2 months ago

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] commented 2 months ago

:white_check_mark: Integration tests have finished successfully!

MarcAstr0 commented 2 months ago

/integration sha=a8c41f62c132e58176f9d976945804dfe3fc4cd4

github-actions[bot] commented 2 months ago

:hourglass: Integration tests are running...

Check their status here 👈

MarcAstr0 commented 2 months ago

@davidverdu your comments about access modifiers and some method names in the ReadModelStore class have been addressed in commit 1786d58d0167e3e16ecb19db614fac40ceaebebf.

github-actions[bot] commented 2 months ago

:white_check_mark: Integration tests have finished successfully!