Closed javiertoledo closed 5 months ago
Oops, looks like you forgot to add a changeset.
⚠️ Please run rush change
and commit the changeset file.
This command will prompt you for a change description and generate a changeset file. You can read more about changesets here.
Remember that you should use the version bump that is appropriate for the change you are making:
Version bump | Meaning |
---|---|
patch |
Bug fixes, documentation changes, etc. |
minor |
New features, non-breaking changes |
major |
Breaking changes |
If you are unsure about which version bump to use, please ask in the comments and we will help you out.
/integration sha=00adf90abd8b29bb0f3eb46c9462a07ff6e9612a
:hourglass: Integration tests are running...
Check their status here 👈
:white_check_mark: Integration tests have finished successfully!
/integration sha=d2e57fecc55aaaf0644d6804b485b6b12ef4ed27
:hourglass: Integration tests are running...
Check their status here 👈
:white_check_mark: Integration tests have finished successfully!
Description
Cleanup of exported methods of the core package to avoid extra levels of indirection. The core index interface has not changed, but I've moved the implementation of the static methods from the
booster.ts
file to theindex.ts
to avoid a level of indirection. TheBoosterApp
type was made redundant as it was just describing theBooster
class signature.Changes
index.ts
Booster
object directly without proxying it through theBoosterApp
typeBoosterApp
type, as theBooster
object already exports the correct signature. This type was used only to type-check loading user apps from the CLI, and while the type was exported, it was not used in practice. Users use theBooster
singleton exported by the core package instead.Booster
class, as they were never exported; thus, removing them is not a breaking change.