search

boostorg / accumulators

An awesome library from Boost
http://boost.org/libs/accumulators
22 stars 54 forks source link

std::abs used without including header in extended_p_square.hpp #50

Open jefftrull opened 3 years ago

jefftrull commented 3 years ago

std::abs needs either <cmath> or <cstdlib> but neither is included. This results in a particularly hairy ambiguous overload problem on some old versions of gcc.

It also may be better to use std::fabs, which is intended for this use case

jefftrull commented 3 years ago

This stackoverflow answer was particularly helpful for me