initialize member variables

boostorg / algorithm

Boost.org algorithm module

http://boost.org/libs/algorithm

Boost Software License 1.0

114 stars 105 forks source link

initialize member variables #10

Closed tempoz closed 9 years ago

tempoz commented 9 years ago

m_Next and m_End are not objects, so do not have constructors, and so are not initialized without explicit value initialization. Also moved the value initialization of m_bEof into the initializer list for consistency's sake. This was uncovered by Coverity issue CID10557.

mclow commented 9 years ago

This looks good to me, but we don't pull into 'master'. We pull into 'develop', let the tests cycle, and then merge into 'master'.

tempoz commented 9 years ago

Sooo, should i move the pull request there?

mclow commented 9 years ago

I manually applied this against the develop branch in ba1894bfde9c5ec981e39c8892c8e8a7e6eab376. Please watch the tests, and ping me in about a few days, and I will merge to master, so this can be part of the 1.58.0 release.