search

boostorg / algorithm

Boost.org algorithm module
http://boost.org/libs/algorithm
Boost Software License 1.0
112 stars 105 forks source link

Ill-formed include guard fix #81

Closed tony-space closed 3 years ago

tony-space commented 3 years ago

I've discovered that if one includes transform_reduce.hpp and inclusive_scan.hpp they cannot use functions from the last included header.

The reason is ill-formed include guard in inclusive_scan.hpp, originally copy-pasted from transform_reduce.hpp. I've fixed it.

mclow commented 3 years ago

Thanks for the bug fix. I'm less enamored with the doc fix; I'm not sure that's an improvement.

tony-space commented 3 years ago

I'm less enamored with the doc fix; I'm not sure that's an improvement.

Feel free to change the description as you want. I've copied the description from here: https://en.cppreference.com/w/cpp/algorithm/inclusive_scan

A similar version is available here: https://thrust.github.io/doc/group__prefixsums_ga7109170b96a48fab736e52b75f423464.html

mclow commented 3 years ago

Fixed (w/o the doc update) in 8c26a50. Thank you!