search

boostorg / array

Boost.org array module
http://boost.org/libs/array
21 stars 50 forks source link

Is CMake support for Boost.Array still experimental? #10

Closed mloskot closed 1 year ago

mloskot commented 4 years ago

Is this note up to date?

https://github.com/boostorg/array/blob/e5f4af3dd212608f6a4a639a82f3484234807eec/CMakeLists.txt#L5-L6

CMakeLists.txt have been added across many if not most libraries now, and Boost.Array seems to be missing the following

  1. project(boost_array VERSION "${BOOST_SUPERPROJECT_VERSION}" LANGUAGES CXX)

  2. Install

# boost_install requires PROJECT_VERSION
# Without the superproject, we don't have any, so skip installation
if(BOOST_SUPERPROJECT_VERSION)
  include(BoostInstall)
  boost_install(TARGETS boost_assert HEADER_DIRECTORY include/)
endif()
  1. Tests
# BUILD_TESTING is the standard CTest variable that enables testing
if(BUILD_TESTING)
  add_subdirectory(test)
endif()

Question is if these are applicable or perhaps Boost.Array has a different plan.

vardhanyadav1714 commented 3 years ago

Bro can you tell me more about it i wanna make my first contribution