search

boostorg / array

Boost.org array module
http://boost.org/libs/array
21 stars 50 forks source link

Replace Boost.Test with lightweight_test from Boost.Core #6

Closed mloskot closed 5 years ago

mloskot commented 6 years ago

The tests do not require fully-featured testing framework. The lightweight_test alternative should also save on build times.

Motivation is drawn from recent discussions on #boost channel at cpplang.slack.com, about preferring the lightweight_test wherever possible, also to cut number of inter-dependencies in Boost.

mclow commented 6 years ago

@mloskot - the problem with discussions on the slack channel (as opposed to the mailing list) is that they are not archived, and can't be reviewed later.

mloskot commented 6 years ago

@mclow Right. However, I think that even if I did not mention it, the rationale behind the change should be clear enough.

pdimov commented 6 years ago

You forgot to return boost::report_errors(); :-)

mclow commented 6 years ago

It's not the motivation that I'm missing, but rather the discussion of the pros and the cons.

mloskot commented 6 years ago

@pdimov Thank you. I've updated the pull request.

@mclow The discussion was not very extensive, just that for simple needs lightweight_test should be enough, less dependency may decrease overall maintenance hassle, and such.

Quoting @mjcaisse

Boost.Test is in a peculiar position of being a dependency for so many pre-c++11 supporting libraries. As such it has a different set of constraints.

mclow commented 5 years ago

Committed a modified version of this as 453cf59