search

boostorg / bcp

Boost.org bcp module
http://boost.org/libs/bcp
Other
14 stars 34 forks source link

Remove usage of deprecated and removed Boost.Filesystem APIs #18

Closed Lastique closed 5 months ago

Lastique commented 6 months ago

The b2 crash in the CI is reported here: https://github.com/bfgroup/b2/issues/367.

jzmaddock commented 6 months ago

Thanks for this!

pdimov commented 5 months ago

bcp doesn't seem to build in 1.85 because this PR hasn't been merged.

Lastique commented 5 months ago

I suspect, it wasn't merged because of the b2 issue. I think, this can be merged despite that issue, if only to fix the build.

Note: the first commit in this PR fixes the compilation, the second one updates the dependencies that should fix the CI once b2 is fixed.

pdimov commented 5 months ago

The b2 issue is unrelated. Not merging this won't fix it.

jzmaddock commented 5 months ago

My bad. I didn't merge because we can't tell if the patch is really working until the tests run... (I appreciate it compiles, but that's not quite the same thing as working).

pdimov commented 5 months ago

Rene says it doesn't crash for him, so let's close and reopen and see if that helps. :-)

pdimov commented 5 months ago

Nope, still crashes. @grafikrobot

Lastique commented 5 months ago

Note that the CI uses the b2 version that was released in Boost.

grafikrobot commented 5 months ago

The B2 problem was not technically a B2 problem. It was actually a Predef problem. But only the Boost Predef, not the independent Hash Predef. But also none of the following will make the BCP tests work. As BCP is not copying the correct predef/tools/check/predef.jam file. The following changes will prevent the stack overflow crash:

And saying again.. None of those changes will make this PR build. As the tip of the problem is that BCP doesn't copy predef/tools/check/predef.jam.

Lastique commented 5 months ago

Thanks, Rene. I've added the dependency on libs/predef/tools/check in addition to libs/predef/check.

Lastique commented 5 months ago

@jzmaddock Could you merge this, please?

kwaegel commented 1 month ago

Is this fixed, or is it still waiting for some of the predef PRs to get merged? I'm still seeing the same error messages trying to run BCP from the Boost 1.86.0 tarball release.

[edit] There is another ticket open about this, saying the fix has been merged to the develop branch but not the master branch that the boost repo tracks: https://github.com/boostorg/bcp/pull/18

Lastique commented 1 month ago

This wasn't merged to master before 1.86.0, so it didn't make it to the release. It is merged now, so it should make it into the next one.