search

boostorg / boost_install

8 stars 30 forks source link

Install .dll files into bin directory #32

Open markand opened 5 years ago

markand commented 5 years ago

Hello,

On Windows, .dll files are installed in the lib/ directory under the prefix. This is quite awkward and should be installed into bin/ directory as many other projects and conventions do.

Thus, user that adds PATH to a common prefix + bin/ will have runtime dependencies correctly.

komalbharadiya commented 5 years ago

Hey @markand , I am Komal from Pune, India. I'm studying 4th year of engineering. I really want to work on this issue. But since, I am totally novice to open source, could you help me? How do I go about this issue?

pdimov commented 5 years ago

@swatanabe What do you think about this one? I noticed that under Cygwin the DLLs are actually installed in the --bindir and did wonder briefly why we don't do this for "ordinary" Windows.

swatanabe commented 5 years ago

AMDG

On 12/18/2018 05:40 PM, Peter Dimov wrote:

@swatanabe What do you think about this one? I noticed that under Cygwin the DLLs are actually installed in the --bindir and did wonder briefly why we don't do this for "ordinary" Windows.

bin/ is probably better, but I'm uncertain whether it's worth a breaking change at this point.

In Christ, Steven Watanabe

pdimov commented 5 years ago

I looked at the history, and Cygwin was changed in https://github.com/boostorg/build/commit/fe12dc59bb8627eeb33a66ad9efc61cff520fae0 by @vprus, but it's not clear why Windows hasn't been. It definitely sounds like the right thing to do, while we're at it.

markand commented 5 years ago

I'm not sure if this is a real breaking change. The .dll files are never implied in build process, only users are responsible of updating their PATH or copy .dll once packaging. Thus this is not a big deal IMHO.

pdimov commented 5 years ago

We could in principle add --dlldir that defaults to --bindir so that there's a way to get the old behavior.