search

boostorg / boostbook

Boost.org boostbook module
http://boost.org/tools/boostbook
11 stars 31 forks source link

BoostBook outputs H7 headings displayed with link styling #12

Closed evanlenz closed 2 years ago

evanlenz commented 2 years ago

Example: https://www.boost.org/doc/libs/1_78_0/libs/json/doc/html/json/ref/boost__json__value/swap/overload1.html

image

The headings (Synopsis, Description, Complexity, Exception Safety, and Parameters) all are displayed with link styling (blue text, underline-on-hover, etc.). This is because boostbook.css only handles the valid HTML heading elements (up to H6). The imported DocBook stylesheets, however, can sometimes output H7.

evanlenz commented 2 years ago

I will submit a proposed fix that forces <h7> and higher to be rewritten as <h6>. That way, the HTML will be valid, and the CSS won't have to change.

evanlenz commented 2 years ago

@glenfe Do you know if this got integrated into the build? When should we see the effects of it in the Boost release? It doesn't appear to have taken effect in the Boost 1.79.0 release. The same issue is reflected here: https://www.boost.org/doc/libs/1_79_0/libs/json/doc/html/json/ref/boost__json__value/swap/overload1.html

Any ideas?

glenfe commented 2 years ago

@evanlenz I forgot to merge it to master for 1.79.0. I'll make sure it's merged for 1.80.0