search

boostorg / charconv

C++11 compatible charconv
https://www.boost.org/doc/libs/master/libs/charconv/doc/html/charconv.html
Boost Software License 1.0
26 stars 15 forks source link

Fix to_chars errc value for overflow #167

Closed mborland closed 7 months ago

mborland commented 7 months ago

Partially addresses: #166

cppalliance-bot commented 7 months ago

An automated preview of the documentation is available at https://167.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html

cppalliance-bot commented 7 months ago

An automated preview of the documentation is available at https://167.charconv.prtest.cppalliance.org/libs/charconv/doc/html/index.html

codecov[bot] commented 7 months ago

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (0e3d9cf) 92.30% compared to head (1a83f89) 92.30%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/boostorg/charconv/pull/167/graphs/tree.svg?width=650&height=150&src=pr&token=jTnxtbJoTv&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg)](https://app.codecov.io/gh/boostorg/charconv/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg) ```diff @@ Coverage Diff @@ ## develop #167 +/- ## ======================================== Coverage 92.30% 92.30% ======================================== Files 64 64 Lines 8316 8316 ======================================== Hits 7676 7676 Misses 640 640 ``` | [Files](https://app.codecov.io/gh/boostorg/charconv/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg) | Coverage Δ | | |---|---|---| | [test/github\_issue\_152.cpp](https://app.codecov.io/gh/boostorg/charconv/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-dGVzdC9naXRodWJfaXNzdWVfMTUyLmNwcA==) | `98.78% <100.00%> (ø)` | | | [test/github\_issue\_152\_float128.cpp](https://app.codecov.io/gh/boostorg/charconv/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-dGVzdC9naXRodWJfaXNzdWVfMTUyX2Zsb2F0MTI4LmNwcA==) | `100.00% <ø> (ø)` | | | [test/to\_chars.cpp](https://app.codecov.io/gh/boostorg/charconv/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-dGVzdC90b19jaGFycy5jcHA=) | `100.00% <100.00%> (ø)` | | | [...lude/boost/charconv/detail/dragonbox/dragonbox.hpp](https://app.codecov.io/gh/boostorg/charconv/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-aW5jbHVkZS9ib29zdC9jaGFyY29udi9kZXRhaWwvZHJhZ29uYm94L2RyYWdvbmJveC5ocHA=) | `97.38% <80.00%> (ø)` | | | [...lude/boost/charconv/detail/ryu/ryu\_generic\_128.hpp](https://app.codecov.io/gh/boostorg/charconv/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-aW5jbHVkZS9ib29zdC9jaGFyY29udi9kZXRhaWwvcnl1L3J5dV9nZW5lcmljXzEyOC5ocHA=) | `83.62% <0.00%> (ø)` | | | [...de/boost/charconv/detail/to\_chars\_integer\_impl.hpp](https://app.codecov.io/gh/boostorg/charconv/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-aW5jbHVkZS9ib29zdC9jaGFyY29udi9kZXRhaWwvdG9fY2hhcnNfaW50ZWdlcl9pbXBsLmhwcA==) | `96.89% <25.00%> (ø)` | | | [include/boost/charconv/detail/dragonbox/floff.hpp](https://app.codecov.io/gh/boostorg/charconv/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-aW5jbHVkZS9ib29zdC9jaGFyY29udi9kZXRhaWwvZHJhZ29uYm94L2Zsb2ZmLmhwcA==) | `73.60% <50.00%> (ø)` | | | [src/to\_chars.cpp](https://app.codecov.io/gh/boostorg/charconv/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-c3JjL3RvX2NoYXJzLmNwcA==) | `92.59% <16.66%> (ø)` | | | [src/to\_chars\_float\_impl.hpp](https://app.codecov.io/gh/boostorg/charconv/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg#diff-c3JjL3RvX2NoYXJzX2Zsb2F0X2ltcGwuaHBw) | `79.55% <0.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/boostorg/charconv/pull/167?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/boostorg/charconv/pull/167?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). Last update [0e3d9cf...1a83f89](https://app.codecov.io/gh/boostorg/charconv/pull/167?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=boostorg).