boostorg / charconv

C++11 compatible charconv
https://www.boost.org/doc/libs/master/libs/charconv/doc/html/charconv.html
Boost Software License 1.0
26 stars 15 forks source link

Tags linked to the Boost release version #175

Closed yurybura closed 5 months ago

yurybura commented 6 months ago

All libraries have git tags linked to the Boost release version, except charconv. Could you add tag boost-1.85.0.beta1?

pdimov commented 6 months ago

These tags are created by the release manager (@mclow ). It's not clear why Charconv doesn't have them.

pdimov commented 6 months ago

Boost.Scope doesn't seem to have a tag either.

pdimov commented 6 months ago

The --init option is probably missing from git submodule update somewhere in the release scripts/procedures. :-)

mclow commented 5 months ago

Fixed.

mborland commented 5 months ago

The boost-1.85.0 tag is on current develop and the boost-1.85.0.beta1 tag is against a random pre-review merge commit. What actually went out in release since the tags are seemingly incorrect (i.e. not aligned to master)?

mclow commented 5 months ago

Dang - can't get anything right today :-(

The 1.85.0 tag has been fixed. The beta tag should be attached to the last commit on master before the beta release - is that not the case?

mclow commented 5 months ago

The beta tag is indeed screwed up - I picked the wrong date. Will fix immediately.

mborland commented 5 months ago

Dang - can't get anything right today :-(

The 1.85.0 tag has been fixed. The beta tag should be attached to the last commit on master before the beta release - is that not the case?

No it is well behind master (Tagged on commit from 12/11/2023). Scope seems to be in the same position.

mclow commented 5 months ago

Yeah. I did the same thing for scope - looked for the state as of the 1.84.0 release :-( It appears that the 1.85.0 and the 1.85.0.beta1 tag should refer to the same commit - and they do so now.

mborland commented 5 months ago

Looks good now. Thanks for the quick fix.

mclow commented 5 months ago

You're welcome. Sorry for the confusion.