Closed henryiii closed 5 years ago
@henryiii , can you try to add https://github.com/ddemidov/compute/commit/8f77efd0ef1aeeeed09fd097a675daa4eb9da644 to this PR? I believe that should fix the issue.
I think the problem now is that test_kernels.cpp
does not include compute/core.hpp
. And we can not include types.hpp
into the kernel.hpp
, because types.hpp
specializes some templates only declared in kernel.hpp
. So may be the best solution for the failing test would be to either include core.hpp
instead of kernel.hpp
, or include types.hpp
after kernel.hpp
.
It bothers me that include order matters. Clang can even warn if includes are not sorted in alphabetical order.
Couldn't types
include kernel
, since it works on the contents?
Couldn't the types it specializes be declared first?
I believe this fix is okay to add.
Currently, macOS does not support set_arg with some datatypes. This was partially fixed in #737, but it does not work if the user does not manually specify the
<boost/compute/types.hpp>
header manually.This PR is expected to fail to build on macOS on the first build. It will then need to be fixed.
See ddemidov/vexcl#227 for more info.