search

boostorg / compute

A C++ GPU Computing Library for OpenCL
http://boostorg.github.io/compute/
Boost Software License 1.0
1.55k stars 333 forks source link

use std::shuffle for post-C++11 #761

Closed jeffhammond closed 6 years ago

jeffhammond commented 6 years ago

std::random_shuffle was deprecated in C++14 and deleted in C++17. std::shuffle was added in C++11. using it fixes build issues with clang+libc++ when compiling with -std=c++1z.

fixes issue #760

This is my first attempt at contributing.

I do not consider this trivial change to be worthy of copyright, but I work for Intel and will get the open-source contribution paperwork approved ASAP.

jeffhammond commented 6 years ago

I have Intel approval to contribute. ~If it is appropriate to add copyright for a trivial change, then I'll do that.~

Update: I confirmed that Intel does not require me to attach copyright on minor changes like this.

jszuppe commented 6 years ago

If it is appropriate to add copyright for a trivial change, then I'll do that.

It depends on you. Usually, you would add copyright on a bigger change, but that's not a rule.

jszuppe commented 6 years ago

Rebased on develop. I'll merge after Travis-CI confirm everything works.