boostorg / compute

A C++ GPU Computing Library for OpenCL
http://boostorg.github.io/compute/
Boost Software License 1.0
1.55k stars 333 forks source link

opengl_create_shared_context cl_gl_sharing_extension references are in quotes #791

Closed Javanater closed 6 years ago

Javanater commented 6 years ago

In interop/opengl/context.hpp, opengl_create_shared_context initializes the variable cl_gl_sharing_extension to "cl_APPLE_gl_sharing" for APPLE, and "cl_khr_gl_sharing" for all other platforms. The problem is that the cl_gl_sharing_extension variable is in quotes, so the function will always fail with a unsupported_extension_error. See lines 79, 121, and 132.

kylelutz commented 6 years ago

Hi @Javanater,

I'm not sure I fully understand the issue. Can you explain problem you're encountering further (potentially with a reproducible test case demonstrating the failure)?

Thanks!

jszuppe commented 6 years ago

I think it was fixed in https://github.com/boostorg/compute/pull/773.

Javanater commented 6 years ago

It was fixed in #773. Sorry, and Thanks.