search

boostorg / compute

A C++ GPU Computing Library for OpenCL
http://boostorg.github.io/compute/
Boost Software License 1.0
1.55k stars 333 forks source link

Fixes for appveyor and travis #804

Open Zialus opened 5 years ago

Zialus commented 5 years ago

This should make all the current configuration on appveyor and travis build and pass the tests.

I've added two extra configs. VS2017 on Windows and GCC on OSX.

There's a warning while using GCC on OSX that is triggering -Werror and causing that particular setup to fail. I'm not sure if that is expected behaviour.

jszuppe commented 5 years ago

I'll take a look at it. I'm actually also working on fixing/changing Travis CI script (see https://github.com/jszuppe/compute/tree/fix_travis_ci), but I'll definitely include what you did with AppVeyor if it works ok. I'll be doing this during the week, I should finish in the weekend.

jszuppe commented 5 years ago

I was thinking about removing AMD APP SDK, which is deprecated, and using Intel OpenCL instead.

Zialus commented 5 years ago

Please clean caches and re-run CI. The remaining failures are warnings being treated as errors, I think.

Zialus commented 5 years ago

Ok, ignoring the warnings still doesn't make all tests pass. But everything else seems to be working.

Zialus commented 5 years ago

Do you want me to do a rebase and include only the appveyor changes?

jszuppe commented 5 years ago

Do you want me to do a rebase and include only the appveyor changes?

You can do separate PR for that. As for .travis.yml changes I planned to cherry-pick commits which added Intel Platform.

Zialus commented 5 years ago

Here's something you might be interested in checking out. Is that behavior on the Ubuntu images expected?

I'll open a PR with a windows only appveyor config.

jszuppe commented 5 years ago

If you mean the compilation error on 18.04 (in general when using g++ >=6), then I'll be looking into this after adding Intel Platform 2.0 and 2.1 tests to Travis CI script. If you mean the problem on 16.04, then it's the first time I see it.

jszuppe commented 5 years ago

btw. Have you looked into using Windows on Travis CI?

Zialus commented 5 years ago

I have checked it out in the past, but it was still pretty green.

Here's something I just cobbled up together https://travis-ci.com/Zialus/compute/builds/95828633

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-14.8%) to 69.244% when pulling 8f6f1df8758c2477a30c0204c634c602ecc8aa78 on Zialus:ci-fixes into 2135633bc7f6bddaf09ae409a63a83174e89c881 on boostorg:develop.

jszuppe commented 5 years ago

I think you can close this PR and open two new PR for your changes regarding OSX and Windows that would be based on current develop branch. Of course if you have time finalising them.

Zialus commented 5 years ago

I might try that tomorrow. Is there a reason appveyor isn't getting triggered with the new commits?

jszuppe commented 5 years ago

Is there a reason appveyor isn't getting triggered with the new commits?

Webhook stopped working and I don't have access to add it.

Zialus commented 5 years ago

Just to be clear, for this new PR should I branch of from develop instead of master(unlike what's stated in contribute.md)?

jszuppe commented 5 years ago

Yes. When there are already changes in develop that would cause a conflicts it's better to base changes on develop.