search

boostorg / compute

A C++ GPU Computing Library for OpenCL
http://boostorg.github.io/compute/
Boost Software License 1.0
1.56k stars 332 forks source link

Please do not set CMAKE_MODULE_PATH. #874

Open qis opened 2 years ago

qis commented 2 years ago

https://github.com/boostorg/compute/blob/36350b7/CMakeLists.txt#L64 sets CMAKE_MODULE_PATH and overwrites CMake and possibly toolchain and Compiler/Platform settings.

This prevents users from providing find_package scripts or configs that use include(... relative to the default or toolchain CMAKE_MODULE_PATH.

Please replace it with 

list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")

like the hof library does, or

list(INSERT CMAKE_MODULE_PATH 0 ${CMAKE_BINARY_DIR}/cmake)

like the gil does.