boostorg / container_hash

Generic hash function for STL style unordered containers
https://boost.org/libs/container_hash
29 stars 39 forks source link

Add hash_value overload for std::forward_list and test for it #2

Closed zamazan4ik closed 1 year ago

zamazan4ik commented 5 years ago

Hello. In this PR I just add missing from my point of view hash_value overload for std::forward_list.

Please check it and I did something wrong - correct me :)

Thank you.

mclow commented 5 years ago

Alex - the tests have failed; seems they want to push_back on a forward_list.

zamazan4ik commented 5 years ago

Yeah, I see... Ok, I will fix it soon.

zamazan4ik commented 5 years ago

@mclow I fixed the issue with push_front. but test on Travis CI still fails (on Windows works fine). And log on Travis is strange - seems like there is no hash_value overload for std::forward_list. Probably BOOST_NO_CXX11_HDR_FORWARD_LIST macros is not defined on Linux or anything else. Can you look into the issue please?

Thank you.

mclow commented 5 years ago

It seems to me that your test needs to be conditioned on BOOST_NO_CXX11_HDR_FORWARD_LIST.