boostorg / context

305 stars 150 forks source link

Select assembly sources via preprocessor #228

Closed Kojoley closed 1 year ago

Kojoley commented 1 year ago
olk commented 1 year ago

I don't want a big commit containing changes for many different issues - please create one commit for one fix.

Kojoley commented 1 year ago

I don't want a big commit containing changes for many different issues - please create one commit for one fix.

You mean pull request instead of commit? Because currently there is one commit for one thing and I have probably even split it too much.

Kojoley commented 1 year ago

I've removed CI changes from the PR, some of them I've submitted as separate PRs.

Kojoley commented 1 year ago

Ping

olk commented 1 year ago

ty

olk commented 1 year ago

I was forced to revert all you commits because the changes prevented the release (errors on selecting the correct source etc.)

Kojoley commented 8 months ago

I was forced to revert all you commits because the changes prevented the release (errors on selecting the correct source etc.)

It was b2 bug (https://github.com/bfgroup/b2/pull/326), do you interested in trying this again?