search

boostorg / context

305 stars 150 forks source link

The ucontext headers always use code for macOS. #235

Closed ilyakurdyukov closed 1 year ago

ilyakurdyukov commented 1 year ago

This: https://github.com/boostorg/context/blob/6fa6d5c50d120e69b2d8a1c0d2256ee933e94b3b/include/boost/context/fiber_ucontext.hpp#L70

The same in continuation_ucontext.hpp, three such lines in both sources.

Conflicts with "boost/predef/macos.h":

#define BOOST_OS_MACOS BOOST_VERSION_NUMBER_NOT_AVAILABLE

All #ifdef BOOST_OS_MACOS needs to be changed to #if BOOST_OS_MACOS, otherwise the code for macOS is used for any OS!

ilyakurdyukov commented 1 year ago

@eduardvoronkin, your commit https://github.com/boostorg/context/commit/cc106be672f54b71842aa6322fe45bf60ed1d3cc introduced this issue.

olk commented 1 year ago

should be fixed by #236