Open ned14 opened 4 years ago
It's quite possible the guidelines were written well after date-time was in boost (1.23). And is there some actual reported issue from the field other than consistency?
Of course pull requests are accepted, but I'm not planning to spend time fixing something that isn't really broken.
I can supply a sed script which will fix the whole thing for you within a few seconds. Interested?
sure. run it and submit the pull request :)
It's not as easy as that Jeff. I can report bugs in work time. I cannot supply PRs without going through Legal and getting permission for the patchset first. It is what it is.
Ok, that's fair. Send me the script and we'll see if I (or someone else) can work it in.
Thanks for understanding. It is more than frustrating for me to have to tell people exactly how to replicate something which I could send in a PR in less time and effort.
It's not me doing the work which yielded these issues, but I expect to be able to extract the appropriate sed script for this specific library after he's finished validation in a day or two's time. So, I'll be in touch.
Yep, this issue is one of the reasons I stopped being a direct employee, which I realize isn't for everyone. So yep I'm familiar with the ugly corporate restrictions and the frustration it causes.
I only just left the life of a contractor earlier this year for the first time since 2013! As the single breadwinner with small children at home, the recent IT bubble instability worried me too much, so I rejoined the ranks of the salarymen.
I'm not convinced that the preprocessor naming rules need necessarily apply to the include guards for legacy code, but it's not a difficult fix.
The following macros are missing a
BOOST_
prefix, which is against Boost library guidelines: