boostorg / date_time

Boost.org date_time module
http://boost.org/libs/date_time
Boost Software License 1.0
67 stars 95 forks source link

Change greg_month and greg_weekday to be not marked as exported/imported #146

Closed Lastique closed 4 years ago

Lastique commented 4 years ago

Both greg_month and greg_weekday classes are implemented completely in headers, so they need not be marked with BOOST_DATE_TIME_DECL. For consistency with other similar classes, they are now marked with BOOST_SYMBOL_VISIBLE.

This should fix linking errors on Windows/MSVC, where all members of greg_month and greg_weekday classes remain unresolved as they are expected to be implemented in a shared library.

This PR also enables both shared and static linking in AppVeyor CI.

JeffGarland commented 4 years ago

I'm going forward without waiting for linux CI since it was windows that was the issue and appveyor has passed.