Closed p12tic closed 2 years ago
Merging #214 (a8478d4) into develop (f972dc9) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## develop #214 +/- ##
========================================
Coverage 91.74% 91.75%
========================================
Files 77 77
Lines 4823 4827 +4
========================================
+ Hits 4425 4429 +4
Misses 398 398
Impacted Files | Coverage Δ | |
---|---|---|
include/boost/date_time/gregorian/greg_date.hpp | 100.00% <100.00%> (ø) |
|
...boost/date_time/posix_time/posix_time_duration.hpp | 100.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f972dc9...a8478d4. Read the comment docs.
Looks good - thanks!
Fixes #121
Turns out even when all functions without the library are prefixed with constexpr, GCC up to at least v10 does not consider this constructor as constexpr at least when generating code.
The culprit is the assignment to
*this
. Refactoring the code to initialize the instance just once improves code generation significantly. Note that clang since at least v11 does not exhibit this problem.