search

boostorg / dll

Library for comfortable work with DLL and DSO
https://boost.org/libs/dll
52 stars 43 forks source link

Clang and ICC on Windows fixes #33

Closed Kojoley closed 4 years ago

Kojoley commented 4 years ago

There is still have an issue on Clang, because ctti on it returns a space after a comma that delimits template arguments while demangler does not (boost::variant<double, int> vs boost::variant<double,int>).

Also had to fix CI issues. Some of them are not mandatory, but embed-manifest=off part required to Clang on VS2019 image (for some reason Boost.Build does not find mt.exe), dist: trusty required because Travis switched default image to xenial.

Kojoley commented 4 years ago

I do not see Appveyor here, it seems to be not enabled for the repository? Here are results from the PR source slag https://ci.appveyor.com/project/Kojoley/dll/builds/29038837

apolukhin commented 4 years ago

Many many thanks for the fixes!

apolukhin commented 4 years ago

Are you sure this works correctly? I was getting empty BOOST_BRANCH variable. https://travis-ci.com/Kojoley/dll/jobs/259254217

That's strange. I have that line in all the CI and it works pretty well https://github.com/boostorg/variant/blob/c401edba70c9f3668dae55ee1cfa5d9b2c6fc2fc/.travis.yml#L21

Kojoley commented 4 years ago

Probably the repositories have define BOOST_BRANCH in Travis UI? In the fork it fails even on develop branch https://travis-ci.com/Kojoley/dll/jobs/259574420