search

boostorg / dynamic_bitset

Boost.org dynamic_bitset module
http://boost.org/libs/dynamic_bitset
Boost Software License 1.0
38 stars 59 forks source link

Change to non-deprecated boost test usage #46

Closed jeking3 closed 5 years ago

jeking3 commented 5 years ago

The unit tests were using boost/test/minimal which is deprecated.

glenfe commented 5 years ago

Parts of DynamicBitset already use LightweightTest from Core, so the others should probably use it as well (instead of switching to the non-deprecated Test, which is more heavyweight). Addressed in ccb380a1bcf054d406270b74e9f5b626577d776e.

jeking3 commented 5 years ago

You committed code without running it through CI first. Next time please open a pull request first and get build results.

glenfe commented 5 years ago

without running it through CI first

No, just without running it through CI on the boostorg Travis queue (or the jeking3 Appveyor queue). I ran it through CI on the glenfe Travis and Appveyor queue.

jeking3 commented 5 years ago

Ok, cool - thanks.