search

boostorg / exception

Boost.org exception module
http://boost.org/libs/exception
Boost Software License 1.0
15 stars 46 forks source link

error_info_container : let msvc accept a non virtual protected destructor #9

Closed pthom closed 5 years ago

pthom commented 7 years ago

Hi,

Here is a proposition for a patch on error_info_container : it has a non virtual protected destructor (which is legitimate). However, Visual Studio sees this as a bug, if you enable more warnings (as is often required, because the default warning level is insuffficient).

For a full test and working example, see https://github.com/ivsgroup/boost_warnings_minimal_demo

Important: I tested this patch on a raw boost 1.64.0 checkout, I could not test it on the develop branch.

Hoping that this will be useful, Regards, Pascal Thomet

pthom commented 7 years ago

I think the CI build failure is related to an older commit.