search

boostorg / format

Boost.org format module
http://boost.org/libs/format
Boost Software License 1.0
25 stars 51 forks source link

handle volatile arguments to operator% by making a non-volatile copy #48

Closed jeking3 closed 7 years ago

jeking3 commented 7 years ago

handle volatile arguments to operator% by making a non-volatile copy of them before feeding through

Per the standard it isn't safe to cast away volatile, which is why making a copy is the only reasonable course of action.

This fixes #36

jeking3 commented 7 years ago

This passed a build on my fork. Travis on boostorg today is under extreme duress. https://travis-ci.org/jeking3/format/builds/292683351

Looking for a code review, please. Thanks.

jeking3 commented 7 years ago

@pdimov It's a good suggestion, thanks for reviewing the work.