search

boostorg / gil

Boost.GIL - Generic Image Library | Requires C++14 since Boost 1.80
https://boostorg.github.io/gil
Boost Software License 1.0
179 stars 163 forks source link

Added Functionality for Histogram of Oriented Gradients #597

Open Sayan-Chaudhuri opened 3 years ago

Sayan-Chaudhuri commented 3 years ago

Currently there are no feature descriptors in boost gil . Histogram of Oriented Gradients is a very popular feature descriptor that has been applied successfully for tasks such as pedestrian detection in images and videos. The current implementation follows from the same in scikit-image library. Reference Paper- Dalal, N and Triggs, B, Histograms of Oriented Gradients for Human Detection, IEEE Computer Society Conference on Computer Vision and Pattern recognition 2005 San Diego, CA, USA, https://lear.inrialpes.fr/people/triggs/pubs/Dalal-cvpr05.pdf,:DOI:`10.1109/CVPR.2005.177`

Description

References

Tasklist

codejaeger commented 3 years ago

@Sayan-Chaudhuri you might want to take a look at the docs to know some of the intrinsic details about GIL. It had helped me quite a lot. Cheers!

Sayan-Chaudhuri commented 3 years ago

@codejaeger Thanks for your feedback. I have already gone through the docs. If you can kindly say, whether you found anything wrong that can be corrected by reading the docs, otherwise I am unable to understand the issue you are referring to.

codejaeger commented 3 years ago

Oh no, nothing seems wrong. I had thought you did not find the docs since there is a section on image gradients and how to do it faster using native GIL constructs. I also made some comments at the relevant portions of the PR to clarify better.

Sayan-Chaudhuri commented 3 years ago

@lpranam @codejaeger thanks for your valuable feedback

Sayan-Chaudhuri commented 3 years ago

NO. You can't just copy the code!!! Even if everything is open source there are copyrights and license issue you just can't copy the code. Even if there are no issues of copyright or license why would we want to copy the code!? if I wanted to use scikit code I would have used scikit and not GIL.

There comes many issues with copied code, the first is maintenance cost. No one knows how it works so if something goes wrong we have to spend a significant amount of time solving the problem. Reading code is harder than writing code.

another issue comes in the performance, most codes are written in such a way that it is very optimised in terms of performance for their own codebase. if you just copy it they may not perform as good in GIL as they do in scikit.

another problem is with format and code conventions, code is miserably formatted, template parameters are meaninglessly named, inconsistent spacing and blank lines, overall a mess in terms of code readability

most importantly scikits license does not seem to be compatible with boost (not an expert in legal matters). they seem to be more restricted than boost so definitely, we can't use their code in boost

and the list would go on why not to copy code and especially why not to copy a huge chunk of code...

No copyright issues now

codecov[bot] commented 3 years ago

Codecov Report

Merging #597 (476a571) into develop (6e91e4b) will increase coverage by 0.13%. The diff coverage is n/a.

:exclamation: Current head 476a571 differs from pull request most recent head 64f25fe. Consider uploading reports for the commit 64f25fe to get more accurate results

@@             Coverage Diff             @@
##           develop     #597      +/-   ##
===========================================
+ Coverage    78.59%   78.72%   +0.13%     
===========================================
Files          117      118       +1     
Lines         5003     5034      +31     
===========================================
+ Hits          3932     3963      +31     
Misses        1071     1071
Sayan-Chaudhuri commented 3 years ago

Hog_implementation.hpp is a bad name

  • don't mix lower/upper case
  • word implementation is redundant

I also suspect spacebar in your keyboard may be broken :-)

I have now referred to the codes of the existing algorithms in GIL library and have tried to format mine in the same way as those.

Sayan-Chaudhuri commented 3 years ago

@codejaeger Thanks for your valuable suggestion. I am now experimenting with the histogram coded by you. However, I have a question that as per my understanding, you have used an unordered map to build the histogram . The time complexity of an unordered map is O(n). Wont then my program be slower compared to me using N-Dimensional arrays as histograms where time complexity of access is almost O(1)?