search

boostorg / gil

Boost.GIL - Generic Image Library | Requires C++14 since Boost 1.80
https://boostorg.github.io/gil
Boost Software License 1.0
179 stars 163 forks source link

Renamed adaptive_he to adaptive_histogram_equalization #638

Closed Paul92 closed 2 years ago

Paul92 commented 2 years ago

Description

On develop, tests were failing because of missing adaptive_he.cpp, which was renamed to adaptive_histogram_equalization.cpp. Since adaptive_histogram_equalization seems more consistent, I took the liberty to modify all the occurences of adaptive_he to `adaptive_histogram_equalization.

References

Tasklist

Paul92 commented 2 years ago

Thanks for your comment. It's either me being confused or not making myself clear, but the problem was that the tests weren't working since adaptive_histogram_equalization.cpp was already renamed (hence the tests not working) - I just renamed the rest.

sdebionne commented 2 years ago

Maybe the confusion comes from the fact that this MR also renames the documentation .md file for consistency (which is fine).

sdebionne commented 2 years ago

I believe the failing pipelines have nothing to do with the changes introduced in this PR:

testing.capture-output bin.v2/libs/gil/test/extension/io/simple_all_formats.test/gcc-8/release/cxxstd-2a-iso/threading-multi/visibility-hidden/simple_all_formats.run
====== BEGIN OUTPUT ======
Segmentation fault (core dumped)

EXIT STATUS: 139
====== END OUTPUT ======

The runners are probably running out of memory (or cxxstd-2a-iso is buggy in GCC8).

mloskot commented 2 years ago

@sdebionne Yes, I think this can be merged.

It's shame the CI is still broken, but my work here https://github.com/mloskot/gil/pull/3 is still being kind of blocked by https://github.com/boostorg/filesystem/issues/226 aka https://github.com/boostorg/cmake/issues/17

Although with this https://github.com/boostorg/gil/pull/636 merged, it should be easier to work around it. I'll pick the task this week yet.