refactor: Renamed io/dynamic_io_new.hpp to io/detail/dynamic.hpp

boostorg / gil

Boost.GIL - Generic Image Library | Requires C++14 since Boost 1.80

https://boostorg.github.io/gil

Boost Software License 1.0

178 stars 163 forks source link

refactor: Renamed io/dynamic_io_new.hpp to io/detail/dynamic.hpp #653

Closed marco-langer closed 2 years ago

marco-langer commented 2 years ago

Description

Renamed io/dynamic_io_new.hpp to io/detail/dynamic.hpp.

The function construct_matched was only used by other detail headers, thus I moved the function into the detail namespace as already suggested in the issue. Additionally I moved the whole file into the detail directory, because it only contains details now.

References

Fixes #189

Tasklist

[x] Ensure all CI builds pass
[x] Review and approve

simmplecoder commented 2 years ago

I guess I am a bit late, but this commit seems to be the one breaking the build for me. In all of the write.hpp headers of I/O extensions, dynamic.hpp is missing and that causes build error. Without including dynamic.hpp, the build will complain that dynamic_io_fnobj is not present in detail namespace. Including the header fixes the problem.

sdebionne commented 2 years ago

dynamic_io_new.hpp was indeed renamed/moved in the include list of read.hpp while it was completely removed from write.hpp.