refactor: Move GSoC 2020 features to extension

boostorg / gil

Boost.GIL - Generic Image Library | Requires C++14 since Boost 1.80

https://boostorg.github.io/gil

Boost Software License 1.0

178 stars 163 forks source link

refactor: Move GSoC 2020 features to extension #673

Closed simmplecoder closed 2 years ago

simmplecoder commented 2 years ago

Description

Moves functionality implemented in GSoC 2020 by Olzhas into extension and improves documentation with some fiixups needed.

References

Discussion link.

Tasklist

[X] Move rasterization to extension
[X] Move Hough transform to extension
[X] Move anisotropic diffusion into extension
~~[ ] Add release notes~~ Were already added
[x] Ensure all CI builds pass
[x] Review and approve

simmplecoder commented 2 years ago

This commit is not complete, but is ready to be merged if needed. I will keep adding on it by strict improvements (so that each commit would still leave it in mergeable state).

marco-langer commented 2 years ago

Some refactor suggestions:

line.hpp is missing include guards.
d_first in line.hpp and circle.hpp models OutputIterator category and not RandomAccessIterator category
mixing of east and west const in line.hpp
trailing return types
namespace boost { namespace gil { should be a one-liner in line.hpp

mloskot commented 2 years ago

Thank you @marco-langer AFAIK, @simmplecoder is preparing to move home at the moment.

I think we should merge this, unless you think this PR should not be merged, then we can apply further refactoring in separate PRs.