boostorg / gil

Boost.GIL - Generic Image Library | Requires C++14 since Boost 1.80
https://boostorg.github.io/gil
Boost Software License 1.0
178 stars 163 forks source link

refactor: Move base_channel_type_impl to detail namespace #681

Open marco-langer opened 2 years ago

marco-langer commented 2 years ago

Description

This PR moves base_channel_type_impl to detail namespace.

Tasklist

mloskot commented 2 years ago

@marco-langer Why closing?

marco-langer commented 2 years ago

@mloskot I wanted to discuss this PR with you before working on it again, but I thought currently the Boost 1.80 PRs are more important.

I think those structs belong to the detail namespace, but they are currently not. However, just moving stuff around would violate boosts deprecation policy, right?

So, some of my solutions:

mloskot commented 2 years ago

OK. You can always turn PR to Draft.

Boost 1.80 PRs are more important.

Yes, indeed.

However, just moving stuff around would violate boosts deprecation policy, right?

Generally speaking, yes. However, I doubt any user directly refers to base_channel_type_impl type. We can not exclude such possibility though.

Let's postpone it.