boostorg / gil

Boost.GIL - Generic Image Library | Requires C++14 since Boost 1.80
https://boostorg.github.io/gil
Boost Software License 1.0
178 stars 163 forks source link

refactor: ellipse rasterizer #692

Closed marco-langer closed 2 years ago

marco-langer commented 2 years ago

Description

This PR implements some of the mentioned issues in my other comment regarding the ellipse rasterizer, namely:

There are still some open questions, e.g. why circle/line and ellipse rasterizer have different signedness for point types and why they implement the call operator differently. However, I am not sure if we are able to find any consensus on these topics before the deadline for Boost 1.80.

Tasklist

codecov[bot] commented 2 years ago

Codecov Report

Merging #692 (7279ffa) into develop (151fd9c) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #692   +/-   ##
========================================
  Coverage    80.32%   80.32%           
========================================
  Files          117      117           
  Lines         5032     5032           
========================================
  Hits          4042     4042           
  Misses         990      990