Open marco-langer opened 2 years ago
Merging #708 (7e87ecd) into develop (573ba13) will decrease coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## develop #708 +/- ##
===========================================
- Coverage 81.10% 81.10% -0.01%
===========================================
Files 117 117
Lines 5171 5170 -1
===========================================
- Hits 4194 4193 -1
Misses 977 977
Is this still a draft?
I wanted to think a second time about these core library changes before rushing them as a last minute change into the next release.
destruct_range
show up in the CI? Is this dead code? Should we add more test cases? Is this part, which deals with destructing non-trivial-destructible pixel types, some kind of academic over-engineering which has no real world application (otherwise there would have been already bug reports?)?I agree with your points @marco-langer
I also was wondering about the actual redundancy of the std::copy
thing.
Let's postpone it after 1.80 is out - it's already too late for major changes (other than tweaking internal stuff like CI or CMake configs).
Description
This PR fixes some minor issues in algorithm.hpp:
Tasklist