fix: Convolution in convolve_2d.

boostorg / gil

Boost.GIL - Generic Image Library | Requires C++14 since Boost 1.80

https://boostorg.github.io/gil

Boost Software License 1.0

178 stars 164 forks source link

fix: Convolution in convolve_2d. #723

Closed cgringmuth closed 1 year ago

cgringmuth commented 1 year ago

Description

This PR fixes the issue explained in #722.

References

Tasklist

[x] Add test case(s)
[x] Ensure all CI builds pass
[x] Review and approve

mloskot commented 1 year ago

The fix looks good to me, https://en.wikipedia.org/wiki/Sobel_operator also agrees

Since the previous values come from #392, I'd give @simmplecoder a chance to check the proposed fix. If none arrives and our tests are green, I'm happy to merge it.

Thank you!