Closed nicolacandussi closed 1 year ago
Great, thanks!
I will do my best to, over next days, investigate the CI failures with some older compilers, e.g.
====== BEGIN OUTPUT ======
libs/gil/test/extension/dynamic_image/image_view_factory.cpp(148): test 'equal_pixels_values(result_view, gil::const_view(expected_image), 1e-3f)' failed in function 'static void test_color_converted_view::run()'
1 error detected.
EXIT STATUS: 1
====== END OUTPUT ======
I fixed the failing tests on Windows, that will probably fix the other CI failures for older compilers
Is there anything else I can do to get this PR merged? There are other similar issues in dynamic_image/image_view_factory.hpp that I would like to fix after this PR is closed.
Description
The function color_converted_view for dynamic views with a custom color converter ignores the provided color converter. This pr fixes this issue as well as some compilation failures related to it. A corresponding test is included