boostorg / gil

Boost.GIL - Generic Image Library | Requires C++14 since Boost 1.80
https://boostorg.github.io/gil
Boost Software License 1.0
178 stars 164 forks source link

Make locator.hpp self contained #729

Closed sdebionne closed 1 year ago

sdebionne commented 1 year ago

Description

locator implementation uses make_step_iterator() but step_iterator.hpp is not included.

Tasklist

sdebionne commented 1 year ago

This fixes the following issue:


boost/gil/locator.hpp:258:32: error: 'make_step_iterator' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
  258 |         : _p(make_step_iterator(loc.x(),(transpose ? loc.row_size() : loc.pixel_size())*x_step),
      |              ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
note: 'template<class I> typename boost::gil::dynamic_x_step_type<T>::type boost::gil::make_step_iterator(const I&, std::ptrdiff_t)' declared here, later in the translation unit
sdebionne commented 1 year ago

@mloskot Do you think this little change could make it to master for 1.82?

mloskot commented 1 year ago

@sdebionne I see no reason why not, unless the release managers object it.