Portable minmax Win32-API workaround #744

boostorg / gil

Boost.GIL - Generic Image Library | Requires C++14 since Boost 1.80

https://boostorg.github.io/gil

Boost Software License 1.0

178 stars 164 forks source link

Portable minmax Win32-API workaround #744 #745

Closed ckormanyos closed 4 months ago

ckormanyos commented 4 months ago

Description

The purpose of this PR is to work around min/max macro conflicts with windows.h when using Win32-API programming on MSVC (in Windows). Unfortunately windows.h defines min() and max() macros that conflict with the standard C++ ones.

Tasklist

[x] Ensure all CI builds pass
[x] Review and approve

ckormanyos commented 4 months ago

The selected solution method uses parentheses like (std::min)().
Do Not in this PR resort to #define NOMINMAX.

ckormanyos commented 4 months ago

Hi @mloskot this one cycled green and I think the trivial changes are ready for rewiew.