search

boostorg / graph

Boost.org graph module
http://boost.org/libs/graph
326 stars 208 forks source link

Ubuntu Bionic is deprecated and GitHub will no longer host CI workers running on it #336

Closed daankolthof closed 1 year ago

daankolthof commented 1 year ago

GitHub blog: https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/

Also fixes:

Hopefully after this PR is merged the CI builds actually succeed for the develop branch. After that, new features can be implemented.

daankolthof commented 1 year ago

@jeremy-murphy I would like to have this (pre-)approved as it's blocking everything else and thus needs to be merged as soon as possible.

jeremy-murphy commented 1 year ago

Looks good, but it's late at night for me so I'll merge it in the morning after I have a complete check.

jeremy-murphy commented 1 year ago

Awesome, thanks for making those changes!

daankolthof commented 1 year ago

Thanks for merging this @jeremy-murphy, maybe we add the latest versions of the GitHub Action Runners? See https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources. This obviously depends on Boost's strategy for integration testing, which I don't know much about.

jeremy-murphy commented 1 year ago

Thanks for merging this @jeremy-murphy, maybe we add the latest versions of the GitHub Action Runners? See https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources. This obviously depends on Boost's strategy for integration testing, which I don't know much about.

The Boost organization provides resources, but each library has their own strategy.

I support adding the latest Ubuntu image as a runner. Let's not use the xxx-latest label, though, as that causes unwanted surprises when they change it to point to a new image. :)

daankolthof commented 1 year ago

Thanks for merging this @jeremy-murphy, maybe we add the latest versions of the GitHub Action Runners? See https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources. This obviously depends on Boost's strategy for integration testing, which I don't know much about.

The Boost organization provides resources, but each library has their own strategy.

I support adding the latest Ubuntu image as a runner. Let's not use the xxx-latest label, though, as that causes unwanted surprises when they change it to point to a new image. :)

Sounds good! If you could create an Issue, I can pick it up sometime in May.