search

boostorg / heap

Boost.Heap
https://boost.org/libs/heap
18 stars 39 forks source link

Fix MSVC compilation #29

Closed glenfe closed 4 years ago

timblechmann commented 4 years ago

@glenfe thanks a lot! especially for the appveyor integration. there's one build failure with msvc-12.0, i'm wondering if we might want to disable that configuration. any thoughts on this?

glenfe commented 4 years ago

@timblechmann Since it's just the forward declarations in mutable_heap_test.cpp that MSVC 12 has a problem with, I've suppressed those in the unit test. This way we still test MSVC 12 for all the other supported Heap features.

timblechmann commented 4 years ago

@glenfe great! i'll merge once the builds are green. thanks a lot!

glenfe commented 4 years ago

@timblechmann Thanks (all green now).

glenfe commented 4 years ago

Good to merge to master?