Missing noexcept specifiers

boostorg / heap

Boost.Heap

https://boost.org/libs/heap

18 stars 39 forks source link

Missing noexcept specifiers #5

Closed apolukhin closed 8 years ago

apolukhin commented 8 years ago

Move constructors and move assignments of heaps do not throw exceptions, but are not marked with noexcept. This leads to regressions when heaps are used in std::vector, or when heap is a member of a class with default move constructors/assignments.

Please mark all the nonthrowing methods with BOOST_NOEXCEPT, or at least mark move constructors/assignments.

timblechmann commented 8 years ago

boost.heap is basically in maintenance mode for me atm, but i'm more than happy to review and merge pull requests!

apolukhin commented 8 years ago

OK, I'll try to make it soon.

timblechmann commented 8 years ago

thnx for the PR