search

boostorg / histogram

Fast multi-dimensional generalized histogram with convenient interface for C++14
Boost Software License 1.0
315 stars 72 forks source link

fix more warnings? #176

Closed HDembinski closed 5 years ago

HDembinski commented 5 years ago

Henry suggests to make histogram compile cleanly with -Wconversion -Wsign-conversion enabled. The only Boost libs which do that are unordered, container_hash, and gil. Out of these, only gil is a "high-level" library like histogram.

Other warnings to possibly enable: -pedantic -Wstrict-aliasing -fstrict-aliasing -Wextra -Wsign-promo -Wunused-parameter -Wconversion -Wfloat-equal -Wshadow -Wcast-align

HDembinski commented 5 years ago

The following warnings flags will be supported: -pedantic -Wextra -Wsign-compare -Wstrict-aliasing -fstrict-aliasing -Wconversion and -Wsign-conversion litter the numerical code with countless casts that obfuscate the code. I tried this and it added nothing useful.